feat: add fetch timeout [INS-3911] #7467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
changed the title
|
5xx seems too broadly scoped a backend validation error would cause a bunch of retries. |
CurryYangxx
commented
Jun 3, 2024
@jackkav I discussed with @notjaywu , and he advice client could retry when there is a server error resposne, so we decided to set 429 and 5xx.If you have any idea, we could talk about it here or in this ticket INS-3911 |
|
This is a very dangerous change and will contribute to further outages. I would advise removing all retry logic in this PR. |
CurryYangxx
changed the title
gatzjames
approved these changes
Jun 5, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
* remove exponential backoff * feat: improve err message when time out --------- Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: